Move metadata handling in a class. #581
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it a tiny bit easier to make a transition to V3 by having groups/array use an instance to encode/decode instead of refering to the function/module. While for v2 it does not make much difference; I'm expecting instances in V3 to likely be (some of) the pieces that handle extensions, and be passed around in a hierarchy. I currently re-expose the methods at the module level to not change the API/tests, though I expect to wrap them and add deprecation once I've move the Groups/Arrays/Attributes to use those.
6 tasks
|
Handled in #839. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it a tiny bit easier to make a transition to V3 by having
groups/array use an instance to encode/decode instead of refering to the
function/module.
While for v2 it does not make much difference; I'm expecting instances
in V3 to likely be (some of) the pieces that handle extensions, and be
passed around in a hierarchy.
I currently re-expose the methods at the module level to not change the
API/tests, though I expect to wrap them and add deprecation once I've
move the Groups/Arrays/Attributes to use those.